fredia commented on code in PR #25561:
URL: https://github.com/apache/flink/pull/25561#discussion_r1814201601
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java:
##########
@@ -58,6 +58,22 @@ public class ForStOptions {
"The remote directory where ForSt puts its
SST files, fallback to %s if not configured.",
LOCAL_DIRECTORIES.key()));
+ public static final ConfigOption<String> CACHE_DIRECTORY =
+ ConfigOptions.key("state.backend.forst.cache-dir")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ String.format(
+ "The directory where ForSt caches its SST
files, fallback to %s/cache if not configured.",
+ LOCAL_DIRECTORIES.key()));
+
+ public static final ConfigOption<Long> CACHE_CAPACITY =
+ ConfigOptions.key("state.backend.forst.cache-capacity")
+ .longType()
+ .defaultValue(-1L)
+ .withDescription(
+ "The capacity capacity of cache, a negative value
means no cache will be used. When this value is greater than the actual
available space, the actual available space will be used as the upper limit.");
+
Review Comment:
`state.backend.forst.cache-capacity` is changed to
`state.backend.forst.cache.size-based-limit`.
This option is for the `SystemSpaceChecker`, `SystemSpaceChecker` would pick
the maximum of `size-based-limit` and disk space as the upper bound, I think
one option is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
