superdiaodiao commented on code in PR #25081:
URL: https://github.com/apache/flink/pull/25081#discussion_r1814637228
##########
pom.xml:
##########
@@ -2386,6 +2386,9 @@ under the License.
<exclude>org.apache.flink.types.DoubleValue</exclude>
<exclude>org.apache.flink.types.FloatValue</exclude>
<exclude>org.apache.flink.types.NormalizableKey</exclude>
+ <!--
FLINK-35566 promote API in flink-core -->
+
<exclude>org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility</exclude>
+
<exclude>org.apache.flink.api.common.typeutils.TypeSerializerSnapshot#readVersionedSnapshot(org.apache.flink.core.memory.DataInputView,java.lang.ClassLoader)</exclude>
Review Comment:
Without these two `exclude`, two errors will appear when running the `mvn
deploy`:
`There is at least one incompatibility:
org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility.compatibleAfterMigration():CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility.compatibleAsIs():CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility.compatibleWithReconfiguredSerializer(org.apache.flink.api.common.typeutils.TypeSerializer):CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility.incompatible():CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.flink.api.common.typeutils.TypeSerializerSnapshot.readVersionedSnapshot(org.apache.flink.core.memory.DataInputView,java.lang.ClassLoader):CLASS_GENERIC_TEMPLATE_CHANGED`
`There is at least one incompatibility:
org.apache.flink.api.common.typeutils.TypeSerializerSnapshot.readVersionedSnapshot(org.apache.flink.core.memory.DataInputView,java.lang.ClassLoader):CLASS_GENERIC_TEMPLATE_CHANGED`
May I ask is this way OK? @masteryhx
What's more, I found the CI failure, please refer:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=63265&view=logs&j=2e8cb2f7-b2d3-5c62-9c05-cd756d33a819&t=2dd510a3-5041-5201-6dc3-54d310f68906
It seems that it is not relate to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
