huyuanfeng2018 commented on PR #904: URL: https://github.com/apache/flink-kubernetes-operator/pull/904#issuecomment-2446336165
> Thanks for the PR! This is an interesting idea. See the comments inline. I would prefer to do the refactoring separately, as it distracts from the actual changes at hand (which are relatively small). There is also some value in preserving the Git history of the changes. > > I would prefer to do the refactoring separately > > I agree with @mxm , refactoring should at least be a separate commit. ok, I will revert the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
