huyuanfeng2018 commented on PR #904: URL: https://github.com/apache/flink-kubernetes-operator/pull/904#issuecomment-2482519716
> Looks good to me overall, but I would like to ask you to drop the refactoring commit. The reason is that this code won't be reused via an extra class. It isn't more easily testable. It also doesn't make the code easier to read, and it removes the valuable Git history from the JobVertexScaler file. I hope that makes sense. Thanks for the review. Regarding this part of the refactoring, I originally thought that there might be some other logic to modify the parallelism in the future, just like fine-tuning based on numpartitionOrKeygroup here, so I refactored it, But I think your concerns are valid (this would change the git history). So, i have no problem with canceling this part of the refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
