twalthr commented on code in PR #25316:
URL: https://github.com/apache/flink/pull/25316#discussion_r1829717408
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/SqlRewriterUtils.scala:
##########
@@ -130,8 +131,11 @@ object SqlRewriterUtils {
call.getKind match {
case SqlKind.SELECT =>
val sqlSelect = call.asInstanceOf[SqlSelect]
-
- if (targetPosition.nonEmpty && sqlSelect.getSelectList.size() !=
targetPosition.size()) {
+ val identifiersSize = sqlSelect.getSelectList.count(s =>
s.isInstanceOf[SqlIdentifier])
+ if (
+ identifiersSize == 0
Review Comment:
I have a similar question than Jim. What is this line good for? maybe an
inline comment makes sense here with an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
