jnh5y commented on code in PR #25316:
URL: https://github.com/apache/flink/pull/25316#discussion_r1829778233
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/SqlRewriterUtils.scala:
##########
@@ -131,7 +131,7 @@ object SqlRewriterUtils {
call.getKind match {
case SqlKind.SELECT =>
val sqlSelect = call.asInstanceOf[SqlSelect]
- val identifiersSize = sqlSelect.getSelectList.count(s =>
s.isInstanceOf[SqlIdentifier])
+ val identifiersSize = sqlSelect.getSelectList.count(s =>
!SqlIdentifier.STAR.equals(s))
Review Comment:
Interesting. This change makes me think that the columns could some
computation. Is it worth testing that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
