[ 
https://issues.apache.org/jira/browse/FLINK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728761#comment-15728761
 ] 

ASF GitHub Bot commented on FLINK-5276:
---------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/2957

    [FLINK-5276] [eg] Check for null when archiving prior execution attempts

    The `EvictingBoundedList` returns the default value for all evicted 
elements. This could lead to NPE when archiving an `ExecutionVertex`.
    
    /cc @StefanRRichter 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 5276-archive_execvertex_npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2957
    
----
commit c1f90b70cedc7c5d942a67dcc0b12068dbf5acd7
Author: Ufuk Celebi <[email protected]>
Date:   2016-12-07T13:26:35Z

    [FLINK-5276] [eg] Check for null when archiving prior execution attempts

----


> ExecutionVertex archiving can throw NPE with many previous attempts
> -------------------------------------------------------------------
>
>                 Key: FLINK-5276
>                 URL: https://issues.apache.org/jira/browse/FLINK-5276
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>             Fix For: 1.1.4
>
>
> I saw a NPE while archiving a ExecutionVertex:
> {code}
> execution graph 
> org.apache.flink.runtime.executiongraph.ExecutionGraph@c4e0722 for archiving.
> java.lang.NullPointerException: null
>       at 
> org.apache.flink.runtime.executiongraph.ExecutionVertex.prepareForArchiving(ExecutionVertex.java:583)
>       at 
> org.apache.flink.runtime.executiongraph.ExecutionJobVertex.prepareForArchiving(ExecutionJobVertex.java:439)
>       at 
> org.apache.flink.runtime.executiongraph.ExecutionGraph.prepareForArchiving(ExecutionGraph.java:1042)
> ...
> {code}
> I think this is due to the newly introduced {{EvictingBoundedList}} which 
> returns a default element ({{null}})) for evicted elements when iterating 
> over it. 
> This affects the backport to release-1.1 only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to