SamBarker commented on code in PR #911:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/911#discussion_r1835897387
##########
docs/content/docs/operations/helm.md:
##########
@@ -56,6 +56,10 @@ To override single parameters you can use `--set`, for
example:
```
helm install --set image.repository=apache/flink-kubernetes-operator --set
image.tag={{< stable >}}{{< version >}}{{< /stable >}}{{< unstable >}}latest{{<
/unstable >}} flink-kubernetes-operator helm/flink-kubernetes-operator
```
+Note, you should remember to escape some special characters in your `--set`
lines, for example:
Review Comment:
```suggestion
Note, you should escape special characters in your `--set` lines, for
example:
```
##########
helm/flink-kubernetes-operator/conf/log4j-console.properties:
##########
@@ -60,3 +60,6 @@ appender.rolling.strategy.max = 10
# Suppress the irrelevant (wrong) warnings from the Netty channel handler
logger.netty.name =
org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline
logger.netty.level = OFF
+
+# Uncomment this if you want to allow dynamically change logging level
+# monitorInterval = 30
Review Comment:
Yes probably as thats what people expect of configMaps for them to be
editable and picked up without recreating the pod.
##########
docs/content/docs/operations/helm.md:
##########
@@ -56,6 +56,10 @@ To override single parameters you can use `--set`, for
example:
```
helm install --set image.repository=apache/flink-kubernetes-operator --set
image.tag={{< stable >}}{{< version >}}{{< /stable >}}{{< unstable >}}latest{{<
/unstable >}} flink-kubernetes-operator helm/flink-kubernetes-operator
```
+Note, you should remember to escape some special characters in your `--set`
lines, for example:
+```
+helm install --set
defaultConfiguration."log4j-operator\.properties"=rootLogger.level\=DEBUG
flink-kubernetes-operator helm/flink-kubernetes-operator
+```
Review Comment:
Should there be a similar note in `content.zh`?
##########
docs/content.zh/docs/operations/metrics-logging.md:
##########
@@ -193,9 +193,13 @@ defaultConfiguration:
log4j-operator.properties: |+
# Flink Operator Logging Overrides
# rootLogger.level = DEBUG
+ # Uncomment this if you want to allow dynamically change logging level
+ # monitorInterval = 30
Review Comment:
It looks like `monitorInterval` is specified in seconds, based on [this
stackoverflow](https://stackoverflow.com/a/43949522/1389220) answer we can
probably afford to suggest a shorter default.
##########
docs/content/docs/operations/helm.md:
##########
@@ -56,6 +56,10 @@ To override single parameters you can use `--set`, for
example:
```
helm install --set image.repository=apache/flink-kubernetes-operator --set
image.tag={{< stable >}}{{< version >}}{{< /stable >}}{{< unstable >}}latest{{<
/unstable >}} flink-kubernetes-operator helm/flink-kubernetes-operator
```
+Note, you should remember to escape some special characters in your `--set`
lines, for example:
+```
+helm install --set
defaultConfiguration."log4j-operator\.properties"=rootLogger.level\=DEBUG
flink-kubernetes-operator helm/flink-kubernetes-operator
Review Comment:
Would
```suggestion
helm install --set
'defaultConfiguration."log4j-operator.properties"=rootLogger.level=DEBUG
flink-kubernetes-operator' helm/flink-kubernetes-operator
```
work? I think its easier to read and should prevent shell globbing running
amok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
