SamBarker commented on code in PR #25566:
URL: https://github.com/apache/flink/pull/25566#discussion_r1837241184
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/MapView.java:
##########
@@ -88,11 +85,7 @@
* }
*
* }</pre>
- *
- * @param <K> key type
- * @param <V> value type
Review Comment:
The javadoc still seems appropriate here, though its not really adding any
insight
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/MapView.java:
##########
@@ -255,26 +248,4 @@ public static DataType newMapViewDataType(DataType
keyDataType, DataType valueDa
DataTypes.FIELD(
"map", DataTypes.MAP(keyDataType,
valueDataType).bridgedTo(Map.class)));
}
-
- //
--------------------------------------------------------------------------------------------
- // Legacy
- //
--------------------------------------------------------------------------------------------
-
- @Deprecated public transient TypeInformation<?> keyType;
-
- @Deprecated public transient TypeInformation<?> valueType;
-
- /**
- * Creates a {@link MapView} with the specified key and value types.
- *
- * @param keyType The type of keys of the map view.
- * @param valueType The type of values of the map view.
- * @deprecated This method uses the old type system. Please use a {@link
DataTypeHint} instead
- * if the reflective type extraction is not successful.
Review Comment:
Again I think its probably worth retaining the advice from this javadoc
somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
