SamBarker commented on code in PR #25566:
URL: https://github.com/apache/flink/pull/25566#discussion_r1845722082
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/MapView.java:
##########
@@ -256,25 +252,8 @@ public static DataType newMapViewDataType(DataType
keyDataType, DataType valueDa
"map", DataTypes.MAP(keyDataType,
valueDataType).bridgedTo(Map.class)));
}
- //
--------------------------------------------------------------------------------------------
- // Legacy
- //
--------------------------------------------------------------------------------------------
-
- @Deprecated public transient TypeInformation<?> keyType;
-
- @Deprecated public transient TypeInformation<?> valueType;
-
/**
- * Creates a {@link MapView} with the specified key and value types.
- *
- * @param keyType The type of keys of the map view.
- * @param valueType The type of values of the map view.
- * @deprecated This method uses the old type system. Please use a {@link
DataTypeHint} instead
- * if the reflective type extraction is not successful.
+ * {@code MapView(TypeInformation<?> keyType, TypeInformation<?>
valueType)} method was
+ * deprecated and removed. Please use a {@link DataTypeHint} instead.
Review Comment:
This now floats as a comment in the file without being attached to the class
or a method which only makes it useful when viewing sources. I wonder if it
should be part of the javadoc for the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
