davidradl commented on code in PR #138:
URL: 
https://github.com/apache/flink-connector-kafka/pull/138#discussion_r1865676563


##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java:
##########
@@ -156,6 +157,11 @@ public List<PartitionInfo> partitionsFor(String topic) {
         return kafkaProducer.metrics();
     }
 
+    @Override

Review Comment:
   This change seems unrelated to the version change. If it is related please 
could you add a unit test. 
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to