tomncooper commented on code in PR #138:
URL:
https://github.com/apache/flink-connector-kafka/pull/138#discussion_r1865696228
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java:
##########
@@ -156,6 +157,11 @@ public List<PartitionInfo> partitionsFor(String topic) {
return kafkaProducer.metrics();
}
+ @Override
Review Comment:
Because the `Producer` interface has changed between 3.4 and 3.9, this new
method is required in order for the class to compile (I should have mentioned
that in the PR description).
As this class is deprecated anyway and calls the wrapped KafkaProducer's
client instance ID method (which is tested), is a unit test strictly required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
