[ 
https://issues.apache.org/jira/browse/FLINK-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734111#comment-15734111
 ] 

ASF GitHub Bot commented on FLINK-5187:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2968#discussion_r91652189
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java
 ---
    @@ -0,0 +1,698 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.java.typeutils.runtime;
    +
    +import org.apache.flink.api.common.typeutils.CompositeTypeComparator;
    +import org.apache.flink.api.common.typeutils.TypeComparator;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.api.java.tuple.Tuple4;
    +import org.apache.flink.core.memory.DataInputView;
    +import org.apache.flink.core.memory.DataOutputView;
    +import org.apache.flink.core.memory.MemorySegment;
    +import org.apache.flink.types.KeyFieldOutOfBoundsException;
    +import org.apache.flink.types.Row;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.List;
    +
    +import static 
org.apache.flink.api.java.typeutils.runtime.NullMaskUtils.readIntoNullMask;
    +import static org.apache.flink.util.Preconditions.checkArgument;
    +
    +/**
    + * Comparator for {@link Row}
    + */
    +public class RowComparator extends CompositeTypeComparator<Row> {
    +
    +   private static final long serialVersionUID = 1L;
    +   /** The number of fields of the Row */
    +   private final int arity;
    +   /** key positions describe which fields are keys in what order */
    +   private final int[] keyPositions;
    +   /** null-aware comparators for the key fields, in the same order as the 
key fields */
    +   private final NullAwareComparator<Object>[] comparators;
    +   /** serializers to deserialize the first n fields for comparison */
    +   private final TypeSerializer<Object>[] serializers;
    +   /** auxiliary fields for normalized key support */
    +   private final int[] normalizedKeyLengths;
    +   private final int numLeadingNormalizableKeys;
    +   private final int normalizableKeyPrefixLen;
    +   private final boolean invertNormKey;
    +
    +   // null masks for serialized comparison
    +   private final boolean[] nullMask1;
    +   private final boolean[] nullMask2;
    +
    +   // cache for the deserialized key field objects
    +   transient private final Object[] deserializedKeyFields1;
    +   transient private final Object[] deserializedKeyFields2;
    +
    +   /**
    +    * General constructor for RowComparator.
    +    *
    +    * @param arity        the number of fields of the Row
    +    * @param keyPositions key positions describe which fields are keys in 
what order
    +    * @param comparators  non-null-aware comparators for the key fields, 
in the same order as
    +    *                     the key fields
    +    * @param serializers  serializers to deserialize the first n fields 
for comparison
    +    * @param orders       sorting orders for the fields
    +    */
    +   public RowComparator(
    +           int arity,
    +           int[] keyPositions,
    +           TypeComparator<Object>[] comparators,
    +           TypeSerializer<Object>[] serializers,
    +           boolean[] orders) {
    +           this(arity, keyPositions, makeNullAware(comparators, orders), 
serializers);
    +   }
    +
    +
    +   /**
    +    * Intermediate constructor for creating auxiliary fields.
    +    */
    +   private RowComparator(
    +           int arity,
    +           int[] keyPositions,
    +           NullAwareComparator<Object>[] comparators,
    +           TypeSerializer<Object>[] serializers) {
    +           this(
    +                   arity,
    +                   keyPositions,
    +                   comparators,
    +                   serializers,
    +                   createAuxiliaryFields(keyPositions, comparators));
    +   }
    +
    +   /**
    +    * Intermediate constructor for creating auxiliary fields.
    +    */
    +   private RowComparator(
    +           int arity,
    +           int[] keyPositions,
    +           NullAwareComparator<Object>[] comparators,
    +           TypeSerializer<Object>[] serializers,
    +           Tuple4<int[], Integer, Integer, Boolean> auxiliaryFields) {
    +           this(
    +                   arity,
    +                   keyPositions,
    +                   comparators,
    +                   serializers,
    +                   auxiliaryFields.f0,
    +                   auxiliaryFields.f1,
    +                   auxiliaryFields.f2,
    +                   auxiliaryFields.f3);
    +   }
    +
    +   /**
    +    * Intermediate constructor for creating auxiliary fields.
    +    */
    +   private RowComparator(
    --- End diff --
    
    This constructor is used in `duplicate` which I don't want to generate the 
Tuple4 again.


> Create analog of Row in core
> ----------------------------
>
>                 Key: FLINK-5187
>                 URL: https://issues.apache.org/jira/browse/FLINK-5187
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core, Table API & SQL
>            Reporter: Anton Solovev
>            Assignee: Jark Wu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to