Zakelly commented on code in PR #25676:
URL: https://github.com/apache/flink/pull/25676#discussion_r1879321157
##########
flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStStateBackendV2Test.java:
##########
@@ -90,9 +91,13 @@ protected ConfigurableStateBackend getStateBackend() throws
Exception {
Configuration config = new Configuration();
if (hasLocalDir) {
config.set(LOCAL_DIRECTORIES, tempFolderForForStLocal.toString());
+ config.set(USE_INGEST_DB_RESTORE_MODE, true);
}
if (hasRemoteDir) {
config.set(REMOTE_DIRECTORY, tempFolderForForstRemote.toString());
+ // Async state + remote + ingestDB is not supported, because
ingestDB needs to link
+ // files.
+ config.set(USE_INGEST_DB_RESTORE_MODE, false);
Review Comment:
So IIUC only ingest db is tested, what if the delete range?
I'd suggest parameterized related IT cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
