mehdid93 commented on PR #25718: URL: https://github.com/apache/flink/pull/25718#issuecomment-2535315748
> Great contribution, thanks a lot! > > I've also tested the Web UI with this PR and couldn't find any regressions. I found one thing that needs to be addressed with this PR as well, even though I think similar PRs in the recent past haven't addressed this -- so even better to address it now: We are maintaining a NOTICE file which lists all dependencies and dep versions we are using for legal compliance reasons. Many JS dependencies are packaged and distributed (in a minified version) as part of Flink releases. With this legal documentation, we want to make sure that companies using Flink, or distributing Flink don't get into trouble for not listing which open source dependencies they are using. https://github.com/apache/flink/blob/master/flink-runtime-web/src/main/resources/META-INF/NOTICE > > I'm not entirely sure how this list got initially created there. Maybe npm has a method of listing all dependencies? Thank you a lot @rmetzger I tried looking for the tool to update the NOTICE without result, looks like we have to update it manually or is there a tool I missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
