davidradl commented on code in PR #25789:
URL: https://github.com/apache/flink/pull/25789#discussion_r1882312575
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecGroupTableAggregate.java:
##########
@@ -120,16 +119,16 @@ protected Transformation<RowData> translateToPlanInternal(
final AggsHandlerCodeGenerator generator =
new AggsHandlerCodeGenerator(
- new CodeGeneratorContext(
- config,
planner.getFlinkContext().getClassLoader()),
- planner.createRelBuilder(),
-
JavaScalaConversionUtil.toScala(inputRowType.getChildren()),
- // TODO: heap state backend do not copy key
currently,
- // we have to copy input field
- // TODO: copy is not need when state backend
is rocksdb,
- // improve this in future
- // TODO: but other operators do not copy this
input field.....
- true)
+ new CodeGeneratorContext(
+ config,
planner.getFlinkContext().getClassLoader()),
+ planner.createRelBuilder(),
+
JavaScalaConversionUtil.toScala(inputRowType.getChildren()),
+ // TODO: heap state backend do not copy key currently,
Review Comment:
I am not sure of the impact of these TODOs.
it would be worth tracking these TODOs with Jiras and including the numbers
in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
