Au-Miner commented on code in PR #25789:
URL: https://github.com/apache/flink/pull/25789#discussion_r1883733170
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecGroupTableAggregate.java:
##########
@@ -153,16 +152,30 @@ protected Transformation<RowData> translateToPlanInternal(
.map(LogicalTypeDataTypeConverter::fromDataTypeToLogicalType)
.toArray(LogicalType[]::new);
final int inputCountIndex = aggInfoList.getIndexOfCountStar();
- final GroupTableAggFunction aggFunction =
- new GroupTableAggFunction(
- aggsHandler,
- accTypes,
- inputCountIndex,
- generateUpdateBefore,
- generator.isIncrementalUpdate(),
- config.getStateRetentionTime());
- final OneInputStreamOperator<RowData, RowData> operator =
- new KeyedProcessOperator<>(aggFunction);
+ final boolean enableAsyncState =
AggregateUtil.enableAsyncState(config, aggInfoList);
+
+ final OneInputStreamOperator<RowData, RowData> operator;
+ if (!enableAsyncState) {
Review Comment:
I have modified it in the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
