ruanhang1993 commented on code in PR #3510:
URL: https://github.com/apache/flink-cdc/pull/3510#discussion_r1883763218
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/java/org/apache/flink/cdc/connectors/sqlserver/source/read/fetch/SqlServerScanFetchTaskTest.java:
##########
@@ -318,19 +322,32 @@ private List<String> formatResult(List<SourceRecord>
records, DataType dataType)
}
private List<SnapshotSplit> getSnapshotSplits(
- SqlServerSourceConfig sourceConfig, JdbcDataSourceDialect
sourceDialect) {
- String databaseName = sourceConfig.getDatabaseList().get(0);
- List<TableId> tableIdList =
- sourceConfig.getTableList().stream()
- .map(tableId -> TableId.parse(databaseName + "." +
tableId))
- .collect(Collectors.toList());
- final ChunkSplitter chunkSplitter =
sourceDialect.createChunkSplitter(sourceConfig);
-
+ SqlServerSourceConfig sourceConfig, JdbcDataSourceDialect
sourceDialect)
+ throws Exception {
+ List<TableId> discoverTables =
sourceDialect.discoverDataCollections(sourceConfig);
+ OffsetFactory offsetFactory = new LsnFactory();
+ final SnapshotSplitAssigner snapshotSplitAssigner =
+ new SnapshotSplitAssigner<JdbcSourceConfig>(
+ sourceConfig,
+ DEFAULT_PARALLELISM,
+ discoverTables,
+
sourceDialect.isDataCollectionIdCaseSensitive(sourceConfig),
+ sourceDialect,
+ offsetFactory);
+ snapshotSplitAssigner.initEnumeratorMetrics(
+ new SourceEnumeratorMetrics(
+
UnregisteredMetricsGroup.createSplitEnumeratorMetricGroup()));
+ snapshotSplitAssigner.open();
List<SnapshotSplit> snapshotSplitList = new ArrayList<>();
- for (TableId table : tableIdList) {
- Collection<SnapshotSplit> snapshotSplits =
chunkSplitter.generateSplits(table);
- snapshotSplitList.addAll(snapshotSplits);
+ while (true) {
+ Optional<SourceSplitBase> split = snapshotSplitAssigner.getNext();
+ if (split.isPresent()) {
+ snapshotSplitList.add(split.get().asSnapshotSplit());
+ } else {
+ break;
+ }
Review Comment:
Here also need to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
