davidradl commented on code in PR #25595:
URL: https://github.com/apache/flink/pull/25595#discussion_r1888720082
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogTestBase.java:
##########
@@ -177,20 +177,8 @@ protected Map<String, String>
getStreamingTableProperties() {
return new HashMap<String, String>() {
{
put(IS_STREAMING, "true");
- putAll(getGenericFlag(isGeneric()));
+ put(FactoryUtil.CONNECTOR.key(), "hive");
Review Comment:
I wonder why we have introduced the keyword hive into a non-hive specific
module. Can we move the hive specific reference into a hive module as part of
this change? I assume setting this as hive is misleading and not useful for a
non-hive use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
