davidradl commented on code in PR #25595:
URL: https://github.com/apache/flink/pull/25595#discussion_r1890284900
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogTestBase.java:
##########
@@ -168,7 +168,7 @@ protected Map<String, String> getBatchTableProperties() {
return new HashMap<String, String>() {
{
put(IS_STREAMING, "false");
- putAll(getGenericFlag(isGeneric()));
+ put(FactoryUtil.CONNECTOR.key(), "hive");
Review Comment:
as this is now only for hive - does this generic class need to about this
option - can't this be done in hive specific code or in a way that doesn ot
hard code a "hive" literal in a non-hive class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
