snuyanzin commented on code in PR #25805:
URL: https://github.com/apache/flink/pull/25805#discussion_r1890244455
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/ExtractionUtils.java:
##########
@@ -110,30 +112,35 @@ public static boolean isInvokable(Executable executable,
Class<?>... classes) {
if (currentParam == paramCount - 1 && executable.isVarArgs()) {
final Class<?> paramComponent =
executable.getParameterTypes()[currentParam].getComponentType();
- // we have more than 1 classes left so the vararg needs to
consume them all
+ // we have more than one class left so the vararg needs to
consume them all
if (classCount - currentClass > 1) {
while (currentClass < classCount
&& ExtractionUtils.isAssignable(
- classes[currentClass], paramComponent,
true)) {
+ classes[currentClass],
+ paramComponent,
+ true,
+ strictAutoboxing)) {
currentClass++;
}
} else if (currentClass < classCount
- && (parameterMatches(classes[currentClass], param)
- || parameterMatches(classes[currentClass],
paramComponent))) {
+ && (parameterMatches(strictAutoboxing,
classes[currentClass], param)
+ || parameterMatches(
+ strictAutoboxing,
classes[currentClass], paramComponent))) {
currentClass++;
}
}
// entire parameter matches
- else if (parameterMatches(classes[currentClass], param)) {
+ else if (parameterMatches(strictAutoboxing, classes[currentClass],
param)) {
currentClass++;
}
}
// check if all classes have been consumed
return currentClass == classCount;
}
- private static boolean parameterMatches(Class<?> clz, Class<?> param) {
- return clz == null || ExtractionUtils.isAssignable(clz, param, true);
+ private static boolean parameterMatches(
+ boolean strictAutoboxing, Class<?> clz, Class<?> param) {
+ return clz == null || ExtractionUtils.isAssignable(clz, param, true,
strictAutoboxing);
Review Comment:
```suggestion
return clz == null || isAssignable(clz, param, true,
strictAutoboxing);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
