snuyanzin commented on code in PR #25805:
URL: https://github.com/apache/flink/pull/25805#discussion_r1890258761
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionArgumentTemplate.java:
##########
@@ -37,21 +37,29 @@
@Internal
final class FunctionArgumentTemplate {
- final @Nullable DataType dataType;
+ private final @Nullable DataType dataType;
+ private final @Nullable InputGroup inputGroup;
+ private final @Nullable Class<?> conversionClass;
- final @Nullable InputGroup inputGroup;
-
- private FunctionArgumentTemplate(@Nullable DataType dataType, @Nullable
InputGroup inputGroup) {
+ private FunctionArgumentTemplate(
+ @Nullable DataType dataType,
+ @Nullable InputGroup inputGroup,
+ @Nullable Class<?> conversionClass) {
this.dataType = dataType;
this.inputGroup = inputGroup;
+ this.conversionClass = conversionClass;
+ }
+
+ static FunctionArgumentTemplate ofDataType(DataType dataType) {
+ return new FunctionArgumentTemplate(dataType, null, null);
}
- static FunctionArgumentTemplate of(DataType dataType) {
- return new FunctionArgumentTemplate(dataType, null);
+ static FunctionArgumentTemplate ofInputGroup(InputGroup inputGroup) {
+ return new FunctionArgumentTemplate(null, inputGroup, null);
}
- static FunctionArgumentTemplate of(InputGroup inputGroup) {
- return new FunctionArgumentTemplate(null, inputGroup);
+ static FunctionArgumentTemplate ofTable(Class<?> conversionClass) {
Review Comment:
What is relation between `table` and `conversionClass` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]