yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1891230159
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala:
##########
@@ -1303,42 +1304,28 @@ class TemporalTypesTest extends ExpressionTestBase {
// invalid type for the first input
testExpectedSqlException(
"TO_TIMESTAMP_LTZ('test_string_type', 0)",
- "SQL validation failed. From line 1, column 8 to line 1, column 46:
Cannot apply " +
- "'TO_TIMESTAMP_LTZ' to arguments of type 'TO_TIMESTAMP_LTZ(<CHAR(16)>,
<INTEGER>)'. " +
- "Supported form(s): 'TO_TIMESTAMP_LTZ(<CHARACTER>)'\n" +
- "'TO_TIMESTAMP_LTZ(<NUMERIC>)'\n" +
- "'TO_TIMESTAMP_LTZ(<NUMERIC>, <INTEGER>)'\n" +
- "'TO_TIMESTAMP_LTZ(<CHARACTER>, <CHARACTER>)'\n" +
- "'TO_TIMESTAMP_LTZ(<CHARACTER>, <CHARACTER>, <CHARACTER>)'",
Review Comment:
Modified tests to reflect the correct exception message, after cleaning-up
the legacy scala tech stack.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/TimeTravelTest.java:
##########
@@ -133,7 +133,7 @@ void testTimeTravelWithUnsupportedExpression() {
+ " t1 FOR
SYSTEM_TIME AS OF TO_TIMESTAMP_LTZ (0, 3)"))
.isInstanceOf(ValidationException.class)
.hasMessageContaining(
- "Unsupported time travel expression:
TO_TIMESTAMP_LTZ(0, 3) for the expression can not be reduced to a constant by
Flink.");
+ "SQL validation failed. Unsupported time travel
expression: TO_TIMESTAMP_LTZ(0, 3) for the expression can not be reduced to a
constant by Flink.");
Review Comment:
Modified tests to reflect the correct exception message, after cleaning-up
the legacy scala tech stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
