Samrat002 commented on code in PR #25877:
URL: https://github.com/apache/flink/pull/25877#discussion_r1900643543
##########
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java:
##########
@@ -90,6 +93,12 @@ public static ContaineredTaskManagerParameters create(
}
}
+ // set JAVA_HOME
+ String javaHome = config.get(CoreOptions.FLINK_JAVA_HOME);
+ if (!javaHome.isEmpty()) {
Review Comment:
I think `config.get(CoreOptions.FLINK_JAVA_HOME)` will return `""` if the
`env.java.home` is not configured.
Can you add a test case to validate that the default Java home is picked
when `CoreOptions.FLINK_JAVA_HOME` is not set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
