X-czh commented on code in PR #25877:
URL: https://github.com/apache/flink/pull/25877#discussion_r1901461030
##########
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java:
##########
@@ -90,6 +93,12 @@ public static ContaineredTaskManagerParameters create(
}
}
+ // set JAVA_HOME
+ String javaHome = config.get(CoreOptions.FLINK_JAVA_HOME);
+ if (!javaHome.isEmpty()) {
Review Comment:
When `CoreOptions.FLINK_JAVA_HOME` has no default value,
`config.get(CoreOptions.FLINK_JAVA_HOME)` will return `null` if `env.java.home`
is not configured. I'll update the usages to accommodate the default value
change, and add UTs on it. Since we cannot directly test if the default Java
home is picked in UT, I'll test it in the reverse way: if the env `JAVA_HOME`
is not overridden by Flink, then we are good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
