afedulov commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1904746901
##########
flink-core/pom.xml:
##########
@@ -180,6 +180,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Thanks, Piotr, and sorry for the holiday-induced delay. I believe, in this
case, we can reasonably walk the line between adding Mockito and creating a
separate module by employing a tiny bit of reflection to test this "untestable"
SLF4J stuff. Something along these lines:
https://github.com/afedulov/flink/blob/logback-compat-test/flink-core/src/test/java/org/apache/flink/util/MdcLogbackCompatibilityTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
