xuyangzhong commented on code in PR #25566:
URL: https://github.com/apache/flink/pull/25566#discussion_r1905005540
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/typeutils/LegacyDataViewUtils.scala:
##########
@@ -158,20 +157,7 @@ object LegacyDataViewUtils {
"MapView, SortedMapView and ListView only supported at first level
of " +
"accumulators of Pojo type.")
case map: MapViewTypeInfo[_, _] =>
- val mapView = instance match {
- case b: BinaryRawValueData[_] =>
- b.getJavaObject.asInstanceOf[MapView[_, _]]
- case _ =>
- instance.asInstanceOf[MapView[_, _]]
- }
-
- val newTypeInfo =
- if (mapView != null && mapView.keyType != null && mapView.valueType
!= null) {
- // use explicit key value type if user has defined
- new MapViewTypeInfo(mapView.keyType, mapView.valueType)
- } else {
- map
- }
+ val newTypeInfo = map
Review Comment:
Nit:The variable `newTypeInfo` is not needed actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
