snuyanzin commented on code in PR #25898:
URL: https://github.com/apache/flink/pull/25898#discussion_r1905107370
##########
pom.xml:
##########
@@ -124,7 +124,7 @@ under the License.
<flink.shaded.jackson.version>2.15.3</flink.shaded.jackson.version>
<flink.shaded.jsonpath.version>2.7.0</flink.shaded.jsonpath.version>
<flink.markBundledAsOptional>true</flink.markBundledAsOptional>
- <target.java.version>11</target.java.version>
+ <target.java.version>17</target.java.version>
Review Comment:
if we make 17 as default for ci
can we protect ourselves from the case when someone submits a PR with jdk
12-17 features and it passes PR ci, however after being merged fails during
nightly where we have jdk11?
I vaguely guess it is possible with setting `maven-compiler.source`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
