snuyanzin commented on code in PR #25898:
URL: https://github.com/apache/flink/pull/25898#discussion_r1906139229
##########
pom.xml:
##########
@@ -124,7 +124,7 @@ under the License.
<flink.shaded.jackson.version>2.15.3</flink.shaded.jackson.version>
<flink.shaded.jsonpath.version>2.7.0</flink.shaded.jsonpath.version>
<flink.markBundledAsOptional>true</flink.markBundledAsOptional>
- <target.java.version>11</target.java.version>
+ <target.java.version>17</target.java.version>
Review Comment:
no it is different
I tested locally with this PR branch
1. add any java 12-17 feature, e.g. any constant like
```java
final String t =
"""
text block
""";
```
this text block feature came with java 14
2. build it with `./mvnw clean install -DskipTests -Dscala-2.12 -Pfast
-Pskip-webui-build -U -T4`
by default there is java 17 so everything is ok
3. now do same with java11 (also put it into JAVA_HOME) like
`./mvnw clean install -DskipTests -Dscala-2.12 -Pfast -Pskip-webui-build -U
-T4 -Pjava11 -Pjava11-target`
and it fails like
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR]
flink/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcSplitReaderUtil.java:[122,19]
unclosed string literal
[ERROR]
flink/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcSplitReaderUtil.java:[123,5]
not a statement
[ERROR]
flink/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcSplitReaderUtil.java:[123,11]
';' expected
[ERROR]
flink/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcSplitReaderUtil.java:[124,7]
unclosed string literal
[INFO] 4 errors
```
since I put constant in `OrcSplitReaderUtil` it complains about this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
