Jzjsnow commented on code in PR #3802:
URL: https://github.com/apache/flink-cdc/pull/3802#discussion_r1906956507
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/FlushEvent.java:
##########
@@ -17,25 +17,49 @@
package org.apache.flink.cdc.common.event;
+import java.util.Collections;
+import java.util.List;
import java.util.Objects;
/**
* An {@link Event} from {@code SchemaOperator} to notify {@code
DataSinkWriterOperator} that it
* start flushing.
*/
public class FlushEvent implements Event {
+ /** The schema changes from which table. */
+ private final List<TableId> tableIds;
/** Which subTask ID this FlushEvent was initiated from. */
private final int sourceSubTaskId;
- public FlushEvent(int sourceSubTaskId) {
+ /** Flag indicating whether the FlushEvent is sent before a create table
event. */
+ private final SchemaChangeEventType schemaChangeEventType;
+
+ public FlushEvent(int sourceSubTaskId, SchemaChangeEventType
schemaChangeEventType) {
Review Comment:
Thanks for the careful review. In order for the `BucketWrapperFlushEvent` to
retain the full `FlushEvent`'s information, the sink table IDs and schema
change event type are passed in its constructor. So this constructor for
`FlushEvent` is no longer necessary and is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
