yuxiqian commented on code in PR #3802:
URL: https://github.com/apache/flink-cdc/pull/3802#discussion_r1905043255
##########
flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/OceanBaseE2eITCase.java:
##########
Review Comment:
Maybe this change spilt into an individual commit to keep commit history
accurate.
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/FlushEvent.java:
##########
@@ -17,25 +17,46 @@
package org.apache.flink.cdc.common.event;
+import java.util.Collections;
+import java.util.List;
import java.util.Objects;
/**
* An {@link Event} from {@code SchemaOperator} to notify {@code
DataSinkWriterOperator} that it
* start flushing.
*/
public class FlushEvent implements Event {
+ /** The schema changes from which table. */
+ private final List<TableId> tableIds;
/** Which subTask ID this FlushEvent was initiated from. */
private final int sourceSubTaskId;
+ /** Flag indicating whether the FlushEvent is sent before a create table
event. */
+ private final Boolean isForCreateTableEvent;
Review Comment:
I'm wondering if we may need to trace `FlushEvent` more specifically, about
what type of schema change event it was caused by.
If so, we may store a `SchemaChangeEventType` enum value for extensibility.
If it turns out to be unnecessary, at least we can use `boolean` to avoid
[un]boxing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
