lincoln-lil commented on code in PR #25910:
URL: https://github.com/apache/flink/pull/25910#discussion_r1908216631
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversionTestBase.java:
##########
@@ -64,18 +61,11 @@ public class SqlNodeToOperationConversionTestBase {
private final TableConfig tableConfig = TableConfig.getDefault();
protected final Catalog catalog = new
GenericInMemoryCatalog("MockCatalog", "default");
protected final CatalogManager catalogManager =
- CatalogManagerMocks.preparedCatalogManager()
- .defaultCatalog("builtin", catalog)
- .config(
- Configuration.fromMap(
- Collections.singletonMap(
-
ExecutionOptions.RUNTIME_MODE.key(),
-
RuntimeExecutionMode.BATCH.name())))
- .build();
+
CatalogManagerMocks.preparedCatalogManager().defaultCatalog("builtin",
catalog).build();
private final PlannerMocks plannerMocks =
PlannerMocks.newBuilder()
- .withBatchMode(true)
+ .withBatchMode(false)
Review Comment:
This seems should not be changed since row-level update tests need it?
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##########
@@ -480,10 +478,7 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
throw new DatabaseNotExistException(getName(),
tablePath.getDatabaseName());
}
- boolean managedTable = ManagedTableListener.isManagedTable(this,
resolvedTable);
- Table hiveTable =
- HiveTableUtil.instantiateHiveTable(
- tablePath, resolvedTable, hiveConf, managedTable);
+ Table hiveTable = HiveTableUtil.instantiateHiveTable(tablePath,
resolvedTable, hiveConf);
Review Comment:
We should sync the related changes to hive connector repo since it has been
externalized.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/PlannerMocks.java:
##########
@@ -134,7 +135,15 @@ public PlannerContext getPlannerContext() {
public PlannerMocks registerTemporaryTable(String tableName, Schema
tableSchema) {
final CatalogTable table =
- CatalogTable.of(tableSchema, null, Collections.emptyList(),
Collections.emptyMap());
+ CatalogTable.of(
+ tableSchema,
+ null,
+ Collections.emptyList(),
+ Map.of(
+ "connector",
+
TestSimpleDynamicTableSourceFactory.IDENTIFIER(),
+ "bounded",
Review Comment:
Why 'bounded' should always be 'true?'
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -888,19 +888,6 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
verifyExplain(statSet, extraDetails: _*)
}
- /** Verify the explain result for the given sql clause which represents a
[[ModifyOperation]]. */
Review Comment:
Does this utility method only works with managed table? (looks like a
general purpose one that can be reserved)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
