xuyangzhong commented on code in PR #25910:
URL: https://github.com/apache/flink/pull/25910#discussion_r1908293974


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/PlannerMocks.java:
##########
@@ -134,7 +135,15 @@ public PlannerContext getPlannerContext() {
 
     public PlannerMocks registerTemporaryTable(String tableName, Schema 
tableSchema) {
         final CatalogTable table =
-                CatalogTable.of(tableSchema, null, Collections.emptyList(), 
Collections.emptyMap());
+                CatalogTable.of(
+                        tableSchema,
+                        null,
+                        Collections.emptyList(),
+                        Map.of(
+                                "connector",
+                                
TestSimpleDynamicTableSourceFactory.IDENTIFIER(),
+                                "bounded",

Review Comment:
   In reality, true and false are indistinguishable and currently not utilized; 
they simply function as placeholder fields for TestTableSource. I will set the 
'bounded' parameter as optional to avoid any potential misunderstandings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to