Zakelly commented on code in PR #25723:
URL: https://github.com/apache/flink/pull/25723#discussion_r1909824008
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java:
##########
@@ -541,8 +541,10 @@ private void processElementWithoutRowNumber(RowData
inputRow, Collector<RowData>
}
}
- private void flushBufferToState(Tuple2<TopNBuffer, Map<RowData, RankRow>>
bufferEntry)
+ private void flushBufferToState(
Review Comment:
I'd suggest providing a more complete cache also tracking those keys that
are already removed from the cache map but still flushing to the state, to
maintain cache coherence for accessing during flushing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
