xishuaidelin commented on code in PR #25723:
URL: https://github.com/apache/flink/pull/25723#discussion_r1914029626
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/AbstractTopNFunction.java:
##########
@@ -76,9 +79,15 @@ public abstract class AbstractTopNFunction extends
KeyedProcessFunction<RowData,
protected KeyContext keyContext;
Review Comment:
Nit: plz move this field down with non final field.
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/AbstractSyncStateTopNFunction.java:
##########
@@ -72,10 +77,10 @@ public void open(OpenContext openContext) throws Exception {
*
* @param row input record
* @return rank end
- * @throws Exception
Review Comment:
Nit: why delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
