davidradl commented on code in PR #25968:
URL: https://github.com/apache/flink/pull/25968#discussion_r1913292764
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -300,14 +300,29 @@ boolean tryOccupyKey(RecordContext<K> recordContext) {
@Override
public <IN, OUT> InternalStateFuture<OUT> handleRequest(
@Nullable State state, StateRequestType type, @Nullable IN
payload) {
+ return handleRequest(state, type, payload, false);
+ }
+
+ /**
+ * Submit a {@link StateRequest} to this AsyncExecutionController and
trigger it if needed.
+ *
+ * @param state the state to request. Could be {@code null} if the type is
{@link
+ * StateRequestType#SYNC_POINT}.
+ * @param type the type of this request.
+ * @param payload the payload input for this request.
+ * @param overdraft whether to allow overdraft.
Review Comment:
nit: it would be better to call this param allowOverdraught in line with the
was it is referred to elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
