davidradl commented on code in PR #25968:
URL: https://github.com/apache/flink/pull/25968#discussion_r1913386269
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -377,7 +392,7 @@ public void triggerIfNeeded(boolean force) {
stateRequestsBuffer.advanceSeq();
}
- private void seizeCapacity() {
+ private void seizeCapacity(boolean allowOverdraft) {
Review Comment:
I am not sure in what sense this is seizing the capacity. I do like all the
comments - maybe an additional sentence at the start of the comment or in
Javadoc to indicate the intent of the the method at a high level would help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
