twalthr commented on code in PR #25984:
URL: https://github.com/apache/flink/pull/25984#discussion_r1916468298
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkConvertletTable.java:
##########
@@ -145,50 +138,62 @@ private boolean isSetSemanticsWindowTableFunction(SqlCall
call) {
* └─ RexLiteral: 300000:INTERVAL MINUTE
* </pre>
*
- * <p>As a workaround, we flatten the inner sql call and convert it to a
customized {@link
- * RexSetSemanticsTableCall} to preserve partition keys and order keys
+ * <p>Instead, we introduce a customized {@link RexTableArgCall} to
preserve properties of the
+ * table argument (i.e. partition keys and order keys).
*
* <pre>
- * RexSetSemanticsTableCall: SESSION
- * ├─ PartitionKeys: [1, 0]
- * ├─ OrderKeys: []
+ * RexCall: SESSION
+ * ├─ RexTableArgCall: TABLE
+ * │ ├─ InputIndex: 0
+ * │ ├─ PartitionKeys: [1, 0]
+ * │ └─ OrderKeys: []
* ├─ RexCall: DESCRIPTOR(`rowtime`)
* │ └─ RexInputRef: `rowtime`
* └─ RexLiteral: 300000:INTERVAL MINUTE
* </pre>
*/
- private RexNode convertSetSemanticsWindowTableFunction(SqlRexContext cx,
final SqlCall call) {
+ private RexNode convertSetSemanticsArgs(SqlRexContext cx, final SqlCall
call) {
Review Comment:
Note to myself: Will rename this to `convertTableArgs `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
