snuyanzin commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1939113951
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -1290,6 +1353,24 @@ private static long floor(long a, long b) {
}
}
+ private static long floor(long a, int b) {
Review Comment:
Can we have here and for other methods more selfexplainable names ?
currently it is not clear what `a` and `b` mean here.
At the same time looking at logic like
```java
long q = b / NANOS_PER_MILLISECOND;
```
it seems it is not a generic floor, so names should have more context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
