snuyanzin commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1939131169
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -1290,6 +1353,24 @@ private static long floor(long a, long b) {
}
}
+ private static long floor(long a, int b) {
+ long q = b / NANOS_PER_MILLISECOND;
+ if (q < 0) {
+ return a - q;
+ } else {
+ return a;
+ }
+ }
Review Comment:
I guess we do not need this logic
same/similar comment as for `private static long ceil(long a, int b) {`
method
also not clear why we have `a-q` in case of `q < 0`
is it covered by any test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
