laughingman7743 commented on code in PR #156:
URL:
https://github.com/apache/flink-connector-jdbc/pull/156#discussion_r1948021458
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/catalog/AbstractJdbcCatalog.java:
##########
@@ -576,16 +569,6 @@ protected String getSchemaTableName(ObjectPath tablePath) {
throw new UnsupportedOperationException();
}
- /**
- * URL has to be without database, like "jdbc:dialect://localhost:1234/" or
- * "jdbc:dialect://localhost:1234" rather than
"jdbc:dialect://localhost:1234/db".
- */
- protected static void validateJdbcUrl(String url) {
- String[] parts = url.trim().split("\\/+");
-
- checkArgument(parts.length == 2);
- }
-
Review Comment:
In the case of Spanner, the URL is as follows, so I have deleted this
validation.
```
jdbc:cloudspanner://hostname/projects/gcp_project_id/instances/instance_id/databases/database_id
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
