laughingman7743 commented on code in PR #156:
URL:
https://github.com/apache/flink-connector-jdbc/pull/156#discussion_r1948021540
##########
flink-connector-jdbc-spanner/src/test/java/org/apache/flink/connector/jdbc/spanner/SpannerTestBase.java:
##########
@@ -16,27 +16,19 @@
* limitations under the License.
*/
-package org.apache.flink.connector.jdbc.core.database.catalog;
+package org.apache.flink.connector.jdbc.spanner;
-import org.junit.jupiter.api.Test;
+import org.apache.flink.connector.jdbc.spanner.testutils.SpannerDatabase;
+import org.apache.flink.connector.jdbc.testutils.DatabaseMetadata;
+import org.apache.flink.connector.jdbc.testutils.DatabaseTest;
+import org.junit.jupiter.api.extension.ExtendWith;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
+/** Base class for Spanner testing. */
+@ExtendWith(SpannerDatabase.class)
+public interface SpannerTestBase extends DatabaseTest {
-/** Test for {@link AbstractJdbcCatalog}. */
-class AbstractJdbcCatalogTest {
Review Comment:
This class is no longer needed because URL validation has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
