littleeleventhwolf commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1950510807


##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
  */
 enum RocksDBSharedResourcesFactory {
     /** Memory allocated per Slot (shared across slot tasks), managed by 
Flink. */
-    SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+    SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {

Review Comment:
   The change here ultimately results in `reserveMemory` having different 
string owner identifiers. What are the deeper implications of this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to