littleeleventhwolf commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1954569028
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by
Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
No, testing the owner of the `reservedMemory` may not be the most accurate
way to determine if the slot is being managed. Instead, we should explore other
methods that provide a clearer indication of the slot management status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
