autophagy commented on code in PR #26121:
URL: https://github.com/apache/flink/pull/26121#discussion_r1954106011


##########
flink-python/docs/reference/pyflink.table/catalog.rst:
##########
@@ -250,3 +250,84 @@ A CatalogDescriptor is a template for creating a catalog 
instance. It closely re
     :toctree: api/
 
     CatalogDescriptor.of
+
+
+Column
+------
+
+Representation of a column in a :class:`~pyflink.table.ResolvedSchema`.
+
+A table column describes either a 
:class:`pyflink.table.catalog.PhysicalColumn`,
+:class:`pyflink.table.catalog.ComputedColumn`, or 
:class:`pyflink.table.catalog.MetadataColumn`.
+
+Every column is fully resolved. The enclosed 
:class:`~pyflink.table.types.DataType`
+indicates whether the column is a time attribute and thus might differ from 
the original

Review Comment:
   I am not entirely sure what is meant, the docs for this class were just 
pulled from the Java equivalent 
https://nightlies.apache.org/flink/flink-docs-stable/api/java/org/apache/flink/table/catalog/Column.html
 - perhaps it's not necessary to include this in the Python one, since it 
doesn't really 'enclose' the data type like the Java one does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to