autophagy commented on code in PR #26121:
URL: https://github.com/apache/flink/pull/26121#discussion_r1973439719
##########
flink-python/pyflink/table/table_result.py:
##########
@@ -140,9 +141,80 @@ def get_table_schema(self) -> TableSchema:
:rtype: pyflink.table.TableSchema
.. versionadded:: 1.11.0
+ .. deprecated:: 2.1.0
+ Use :func:`TableResult.get_resolved_schema` instead.
"""
return TableSchema(j_table_schema=self._get_java_table_schema())
+ def get_resolved_schema(self) -> ResolvedSchema:
+ """
+ Get the resolved schema of result.
+
+ The schema of DDL, USE, EXPLAIN:
Review Comment:
From the docs of `TableResult.getResolvedSchema`:
https://nightlies.apache.org/flink/flink-docs-release-1.20/api/java/org/apache/flink/table/api/TableResult.html#getResolvedSchema--
- the only change is that I changed `Returns the schema of the result` to `Get
the resolved schema of the result` (though theres a typo here, will fix), to
differentiate it from the deprecated `get_table_schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
