snuyanzin commented on code in PR #26157:
URL: https://github.com/apache/flink/pull/26157#discussion_r1956427182
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala:
##########
@@ -227,6 +232,11 @@ object WindowUtil {
}
val slide = getOperandAsLong(windowCall.operands(2))
val size = getOperandAsLong(windowCall.operands(3))
+ if (slide <= 0 || size <= 0) {
+ throw new TableException(
+ s"HOP table function based aggregate requires slide and size being
positive," +
Review Comment:
> nit2: Just a thought we could have a separate message for each invalid
value.
I have a different opinion about that
1. since it will lead to the fact that once one value is fixed there will be
another issue.
2. i would prefer to have similar approach as in runtime to avoid some
missed cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
