nicusX commented on code in PR #188:
URL:
https://github.com/apache/flink-connector-aws/pull/188#discussion_r1959395783
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/pom.xml:
##########
@@ -102,6 +115,15 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <!-- the kinesis aggregator dependency since it is not available
in maven central -->
+ <!-- look into issue
https://github.com/awslabs/kinesis-aggregation/issues/120 -->
+ <groupId>com.github.awslabs.kinesis-aggregation</groupId>
+ <artifactId>amazon-kinesis-aggregator</artifactId>
Review Comment:
This has Apache 2.0 licence, all good so
https://github.com/awslabs/kinesis-aggregation
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/serialization/KinesisDeserializationSchema.java:
##########
@@ -60,7 +60,7 @@ default void open(DeserializationSchema.InitializationContext
context) throws Ex
* @param output the identifier of the shard the record was sent to
* @throws IOException exception when deserializing record
*/
- void deserialize(Record record, String stream, String shardId,
Collector<T> output)
+ void deserialize(KinesisClientRecord record, String stream, String
shardId, Collector<T> output)
Review Comment:
This is a breaking change to the public interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
