hlteoh37 commented on code in PR #188:
URL:
https://github.com/apache/flink-connector-aws/pull/188#discussion_r1977101009
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/KinesisShardSplitReaderBase.java:
##########
@@ -50,10 +49,10 @@
/** Base implementation of the SplitReader for reading from
KinesisShardSplits. */
@Internal
public abstract class KinesisShardSplitReaderBase
- implements SplitReader<Record, KinesisShardSplit> {
+ implements SplitReader<KinesisClientRecord, KinesisShardSplit> {
Review Comment:
This change actually changes the interface exposed for the KinesisSource, so
it would be a backwards incompatible change. Is there a way we can wrap this
internally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
