fapaul commented on PR #75: URL: https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2671230298
> @fapaul i can try to take a look at it. Question would be if it is still enough to do the fix like i provided it here or if the solution from @tamirsagi here https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-2515475756 would also work. I'm not sure about it because the error seems to come when the flush get an exception. It is then thrown upwords without a chance to close the connection. I prefer the solution via the autoclosable block because your current fix changes the semantics slightly. In case the `flushException` was previously set by the background executor we now overwrite it with this PR. In general, can you maybe share a full stack trace or how you are using the `JdbcOutputFormat`? I am mainly interested in understanding which JdbcSink, in your case, calls the JdbcOutputFormat to make sure we do not miss a case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
